Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BE200 Wifi card option to tech-specs for laptops that offer it. #260

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

leviport
Copy link
Member

I copied the formatting from the GPU section on laptops with multiple GPU options. Feel free to make changes if there's a better way to present this option.

@leviport leviport requested review from jacobgkau and a team August 30, 2024 19:14
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now; do we know what kernel version support is good for on the BE200?

@jacobgkau jacobgkau requested review from a team and removed request for jacobgkau September 3, 2024 15:45
@jacobgkau jacobgkau self-assigned this Sep 3, 2024
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're a little inconsistent, but we generally list options in order from most premium to least premium. I've swapped the WiFi cards around, and fixed up a couple other components on the serw13 page to follow that rule.

Other than that, looks good to me.

@jacobgkau jacobgkau merged commit 9b3ce61 into master Sep 3, 2024
1 check passed
@jacobgkau jacobgkau deleted the be200-wifi branch September 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants